Merge pull request #18 from autowp/develop

SlevomatCodingStandard.Operators.DisallowEqualOperators: prevent risky fix
laminas · Sep 8, 2020 · bfdfbf3 · bfdfbf3
2 parents 72afc6b + 1e995d1
commit bfdfbf3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/src/LaminasCodingStandard/ruleset.xml b/src/LaminasCodingStandard/ruleset.xml
@@ -644,7 +644,7 @@
     </rule>
     <!-- Loose comparison operators SHOULD NOT be used, use strict comparison
          operators instead. -->
-    <rule ref="SlevomatCodingStandard.Operators.DisallowEqualOperators"/>
+    <rule ref="SlevomatCodingStandard.Operators.DisallowEqualOperators" phpcs-only="true"/>
     <!-- The null coalesce operator MUST be used when possible. -->
     <rule ref="SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator"/>
     <!-- Assignment operators SHOULD be used when possible. -->

diff --git a/test/fixable/6.Operators.php b/test/fixable/6.Operators.php
@@ -84,6 +84,7 @@ public function testUseStrictComparisonOperators(): void
     {
         // Loose comparison operators SHOULD NOT be used, use strict comparison
         // operators instead.
+        // Fix that manually.
 
         $foo == 123;
         123 == $foo;

diff --git a/test/fixed/6.Operators.php b/test/fixed/6.Operators.php
@@ -83,11 +83,12 @@ public function testUseStrictComparisonOperators(): void
     {
         // Loose comparison operators SHOULD NOT be used, use strict comparison
         // operators instead.
+        // Fix that manually.
 
-        $foo === 123;
-        123 === $foo;
-        true !== 0.0;
-        false !== true;
+        $foo == 123;
+        123 == $foo;
+        true != 0.0;
+        false <> true;
     }
 
     public function testUseNullCoalesceOperator(): void