Skip to content

Commit

Permalink
Disable Generic.CodeAnalysis.UselessOverridingMethod sniff
Browse files Browse the repository at this point in the history
Fixes #12

The sniff is not working properly in case we are overridding the method
and changing default value of parameters.

Please see:
  * zendframework/zend-coding-standard#12
  * squizlabs/PHP_CodeSniffer#519
  • Loading branch information
michalbundyra committed Jan 28, 2019
1 parent d7d46e0 commit f121784
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/ZendCodingStandard/ruleset.xml
Expand Up @@ -134,7 +134,13 @@
<!-- Forbid final methods in final classes -->
<rule ref="Generic.CodeAnalysis.UnnecessaryFinalModifier"/>
<!-- Forbid useless empty method overrides -->
<!--
The sniff is disabled because it's not working properly in case we change
default value of parameters.
See: https://github.com/zendframework/zend-coding-standard/issues/12
https://github.com/squizlabs/PHP_CodeSniffer/issues/519
<rule ref="Generic.CodeAnalysis.UselessOverridingMethod"/>
-->
<!-- Forbid inline HTML in PHP code -->
<rule ref="Generic.Files.InlineHTML"/>
<!-- Force Unix LF (linefeed) line ending -->
Expand Down

0 comments on commit f121784

Please sign in to comment.