Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GHA CI workflow #60

Merged
merged 1 commit into from May 14, 2021
Merged

Switch to GHA CI workflow #60

merged 1 commit into from May 14, 2021

Conversation

internalsystemerror
Copy link
Member

Switch from Travis CI to use GitHub Actions according to: https://gist.github.com/weierophinney/b003e50c3c2667d08076caf31ebd36a4.

Note: Since no PHP src is provided, the "additional_checks" configuration of .laminas-ci.json is used to run the diff tests, and xmllint is used to check the ruleset.xml. The latter requires laminas/laminas-continuous-integration-action#37 to be merged.

Signed-off-by: Gary Lockett <gary@creativecow.uk>
@geerteltink geerteltink added this to the 2.2.0 milestone May 14, 2021
@geerteltink geerteltink self-assigned this May 14, 2021
{
"name": "Lint ruleset.xml using phpcs.xsd schema",
"job": {
"command": "xmllint --noout --schema vendor/squizlabs/php_codesniffer/phpcs.xsd src/LaminasCodingStandard/ruleset.xml"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xmllint is not installed by default.

Maybe we should move this into it's own action file and then we can install it with this:

- name: Install xmllint
  run: sudo apt-get install libxml2-utils

@geerteltink geerteltink merged commit 972ba9c into laminas:2.2.x May 14, 2021
@internalsystemerror internalsystemerror deleted the feature/gha branch May 14, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants