chore(deps): update dependency slevomat/coding-standard to v8 #75
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
Signed-off-by: Renovate Bot <bot@renovateapp.com> | datasource | package | from | to | | ---------- | ------------------------ | ------ | ----- | | packagist | slevomat/coding-standard | 7.0.18 | 8.3.0 |
Signed-off-by: Geert Eltink <geert.eltink@gmail.com>
geerteltink
force-pushed
the
renovate/slevomat-coding-standard-8.x
branch
from
32a7b0b
to
234e8ae
Compare
| "squizlabs/php_codesniffer": "^3.6", | ||
| "webimpress/coding-standard": "^1.2" | ||
| "dealerdirect/phpcodesniffer-composer-installer": "^0.7.2", | ||
| "slevomat/coding-standard": "^8.3.0", |
There was a problem hiding this comment.
@geerteltink this PR was about bumping slevomat/coding-standard: it would be OK to bump to any latest ^7.x, but ^8.x is a breaking change, and we can't have that in 2.x.
There was a problem hiding this comment.
Thinking about it, I see what you mean. Someone can have their own custom rule set.
slevomat 7 is usable anyway. This PR is to bump to version 8. So I guess merging this into version 3.x is fine. There is no point in updating to 7.x.x. If you install the coding standard you will have the latest 7.x.x ruleset anyway.
There was a problem hiding this comment.
I think that before we move this to 3.x, we need to make sure (tomorrow, next TSC meeting) that everyone is on board with having the next release of laminas/laminas-coding-standard be a major one, perhaps with some long-awaited BC breaks in it.
As found out in many pull requests that update `composer.lock`, `phpstan/phpdoc-parser:1.6` and beyond are incompatible with `slevomat/coding-standard:^7`, and we should therefore restrict the compatibility range (for now) in order to prevent downstream crashes. This can be reverted once we upgrade to `slevomat/coding-standard:^8` (in laminas#75)
As found out in many pull requests that update `composer.lock`, `phpstan/phpdoc-parser:1.6` and beyond are incompatible with `slevomat/coding-standard:^7`, and we should therefore restrict the compatibility range (for now) in order to prevent downstream crashes. This can be reverted once we upgrade to `slevomat/coding-standard:^8` (in laminas#75)
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
|
Hi all, Are there any plans to upgrade Regards! |
|
@underdpt yes, but in Feel free to start a patch for that 👍 |
This PR contains the following updates:
^7.0->^7.0 || ^8.0Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
Read more information about the use of Renovate Bot within Laminas.