Update minimum PHP to 7.4, update laminas/laminas-coding-standard to ~2.4.0, restrict composer <2.3.0 in renovate
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 11, 2022 16:52
Signed-off-by: Gary Lockett <gary@creativecow.uk>
Signed-off-by: Gary Lockett <gary@creativecow.uk>
internalsystemerror
changed the title
laminas/laminas-coding-standard to ~2.4.0, restrict composer <2.3.0 in renovate
gsteel
approved these changes
Sep 12, 2022
|
@gsteel im a bit confused, what are the obvious reasons? I was expecting those to have ran. |
|
No PHP code was touched so in my experience, CS checks and tests don't run - I thought that's how it was supposed to work 🤷♂️ |
|
Oh right, I wasn't aware of that, even if composer packages were updated? Good to know anyway. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
laminas/laminas-coding-standardto~2.4.0(closes Lock file maintenance #45).composer-api-pluginorcomposer/composerbeyond<2.3.0(should allow Lock file maintenance #45 to proceed once regenerated)