Add responsetime/uptime/connection-count to memcache + redis checks #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this change is acceptable, I'd also like to add these stats to the PDOCheck class. |
Ocramius
requested changes
Nov 11, 2022
Comment on lines
+93
to
+97
| $serviceData = [ | ||
| "responseTime" => $responseTime, | ||
| "connections" => (int) $stats[$authority]['curr_connections'], | ||
| "uptime" => (int) $stats[$authority]['uptime'], | ||
| ]; |
There was a problem hiding this comment.
Can we perhaps make the type more precise, by having a ServiceData<{responseTime: float, connections: int, uptime: int}> or such? 🤔
Signed-off-by: Bram Leeda <bram@123inkt.nl>
Added unittest for Memcache(d) constructor's host/port validation Had to update psalm-baseline because we are testing invalid input for $host Signed-off-by: Bram Leeda <bram@123inkt.nl>
…r locally installing the extensions Signed-off-by: Bram Leeda <bram@123inkt.nl>
Ocramius
approved these changes
Nov 11, 2022
Ocramius
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bram Leeda bram@123inkt.nl
Description
Added more CheckResult data values:
Added as a keyed array following DirWritable, or do you prefer a dataclass for this for structured data?
There were no unittests for these classes unfortunately, to test this I'd need to be able to mock the Client instance.