Fixes wrong assertions in the controller test class

[Tyrsson]

Q	A
Documentation	no
Bugfix	yes
BC Break	no
New Feature	no
RFC	no
QA	yes

Description

class from layout.phtml
.container

class from index.phtml
.card

For this test to work as intended it must be passed a class from BOTH files.

Please note the entire test methods name is relevant.
"Index Action View Model Template Rendered Within Layout"

fix:
current

    public function testIndexActionViewModelTemplateRenderedWithinLayout(): void
    {
        $this->dispatch('/', 'GET');
        $this->assertQuery('.container .jumbotron');
    }

changed to:

    public function testIndexActionViewModelTemplateRenderedWithinLayout(): void
    {
        $this->dispatch('/', 'GET');
        $this->assertQuery('body h1');
    }

[froschdesign]

If the test is named "rendered within layout" then this should be tested and this can be done independent from the frontend framework. So my suggestion is to check the title element which is a part of the layout:

laminas-mvc-skeleton/module/Application/view/layout/layout.phtml

Line 10 in e4bfbff

<?= $this->headTitle('Laminas MVC Skeleton')->setSeparator(' - ')->setAutoEscape(false) ?>

[Tyrsson]

Actually,

What the test is doing (and I corrected in my last commit).

It is checking that .container (which is a class from the layout) and .card which is a class rendered in the /index/index.phtml file are both rendered.

Your suggested change will only test that the layout is rendered. This test is intended to test that both the layout.phtml file is rendered and that the actions view file is rendered within it. Which is why the assertQuery() needs to be passed a class from each file.

[Tyrsson]

I updated the original comment as well to clarify :)

[froschdesign]

This test is intended to test that both the layout.phtml file is rendered and that the actions view file is rendered within it.

And this can be done independently of the frontend framework:

• html h1
• html h2
• body h1
• …

[Tyrsson]

Absolutely. Its now:

body h1

[Tyrsson]

Just commenting here so that you know it has been resolved.