Make QA tools available by default #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Xerkus
force-pushed
the
feature/qa-tools
branch
from
a9a974a
to
b55dd0e
Compare
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
gsteel
approved these changes
Nov 28, 2023
| displayDetailsOnTestsThatTriggerErrors="true" | ||
| displayDetailsOnTestsThatTriggerNotices="true" | ||
| displayDetailsOnTestsThatTriggerWarnings="true" | ||
| colors="true" |
There was a problem hiding this comment.
Do you think that failOnWarning, failOnNotice and friends would be too strict?
There was a problem hiding this comment.
I don't think this controls whether phpunit fails on warnings. This makes phpunit report tests that produced warnings or notices in test results.
There was a problem hiding this comment.
Sorry - I meant: Do you think that failOnWarning and friends should be added to PHPUnit's config?
There was a problem hiding this comment.
They should.
Not the decision I am going to make here. We don't use them. Users can tighten configuration themselves.
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Default installation results in tests, static analysis and coding standard tools are unusable. By making sure QA tools are immediately available and passing with
composer test,composer cs-checkandcomposer static-analysiswe can promote their adoption and provide better starting point for our users.I included phpstorm and psalm stubs for container that I often find in my own projects. While it is not a strict relation between class-string id and actual returned instance it tends to be true often enough.