Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for psr/container v2 #188

Merged
merged 1 commit into from
May 2, 2023

Conversation

boesing
Copy link
Member

@boesing boesing commented May 2, 2023

Q A
Documentation no
BC Break yes
New Feature yes

Description

This provides support for psr/container v2.
By merging these changes, ServiceManager#get and ServiceManager#has will also synchronize argument name with ContainerInterface#get and ContainerInterface#has (was $name before these changes).

Closes #92
Supersedes #151

@boesing boesing added this to the 4.0.0 milestone May 2, 2023
@boesing

This comment was marked as outdated.

@boesing boesing linked an issue May 2, 2023 that may be closed by this pull request
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing force-pushed the feature/psr-container-2.0 branch from 7cc7b95 to 98ab717 Compare May 2, 2023 19:29
@boesing boesing merged commit 73e9d80 into laminas:4.0.x May 2, 2023
10 checks passed
@boesing boesing deleted the feature/psr-container-2.0 branch May 2, 2023 19:31
@boesing boesing mentioned this pull request May 2, 2023
@bendavies
Copy link

bendavies commented Oct 11, 2023

hi @boesing . would you accept these changes (allow psr/container v2) to be back ported to v3.x?
after reading #92, i'm not really sure.

reason: symfony 6.4, currently up for release in november, requires psr/container v2

@boesing
Copy link
Member Author

boesing commented Oct 11, 2023

Backporting PSR v2 is impossible due to BC breaking changes to method signatures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update psr/container
2 participants