Mechanical fix/workaround for tests/tools/pyroma/test_pyroma_tool.py
#658
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides a mechanical fix/workaround (ie not a fix at the root cause, please see below for reasoning) for the failed test
Testing steps
master
Clues: the
files.files
are identical on both machines; themessages
indeed differ by two elements:As you can see, the GA results include two additional
pyroma-PYRUNKNOWN
members in themessages
list. My theory is that thesetup.py
file gets a little bit altered (trailing space character, newline character etc - could be anything non-major - something minor) which gives differing results at the point of pyroma run. File system peculiarities, I reckon.PS: I've kept the change to the GA workflow file for possible further testing, I'll remove that if this will get merged. Cheers, fellas 馃嵑
Related Issue
This failing test needs be fixed so we can get #645 in and consequently release a version that supports Python 3.12
Motivation and Context
Fixes failing test
tests/tools/pyroma/test_pyroma_tool.py
How Has This Been Tested?
Types of changes
Checklist: