refactor: revamp picker block #4227
Open
+308
−478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm really sorry for submitting such a big change without any substantial feature updates in the pull request.
Initially, I planned to fix the issue with the picker component not being able to select items using the arrow keys. However, during development, I discovered that
VarReferenceVars
may have multiple nested structures, making it challenging to handle properly withLexicalTypeaheadMenuPlugin
.This PR still includes many useful updates. If you have time, I hope this PR can be merged.
This PR mainly affects the following areas:
Screen.Recording.2024-05-11.at.17.11.40.mov
PromptMenu
andVariableMenu
intoPickerBlockMenuOption
.These changes improve the code structure and organization of the picker block functionality.
Type of Change
How Has This Been Tested?
Input '/' and test the picker block plugin in the prompt editor.
Suggested Checklist:
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsoptional
I have made corresponding changes to the documentationoptional
I have added tests that prove my fix is effective or that my feature worksoptional
New and existing unit tests pass locally with my changes