Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement custom remote backend #2165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

panekj
Copy link
Collaborator

@panekj panekj commented Feb 18, 2023

Closes #1467
Closes #1827
Closes #1481
Closes #1557

  • Added an entry to CHANGELOG.md if this change could be valuable to users

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2023

Codecov Report

Merging #2165 (52ed970) into master (b92c519) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##           master   #2165      +/-   ##
=========================================
- Coverage    8.93%   8.91%   -0.02%     
=========================================
  Files         136     136              
  Lines       59293   59399     +106     
=========================================
+ Hits         5295    5296       +1     
- Misses      53998   54103     +105     
Impacted Files Coverage Δ
lapce-data/src/command.rs 0.00% <ø> (ø)
lapce-data/src/config.rs 0.00% <0.00%> (ø)
lapce-data/src/data.rs 0.00% <0.00%> (ø)
lapce-data/src/palette.rs 3.91% <0.00%> (-0.15%) ⬇️
lapce-data/src/proxy.rs 0.00% <0.00%> (ø)
lapce-ui/src/palette.rs 0.00% <0.00%> (ø)
lapce-ui/src/tab.rs 0.00% <0.00%> (ø)
lapce-ui/src/title.rs 0.00% <0.00%> (ø)
lapce-data/src/keypress/keypress.rs 73.23% <0.00%> (+0.20%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@panekj panekj force-pushed the feat/custom-remote branch 2 times, most recently from a256aa9 to d20735a Compare February 25, 2023 08:55
@thomasaarholt
Copy link

thomasaarholt commented Mar 26, 2023

Will this PR allow vscode-like "attach to running container" style connections? Those are used for connecting into docker containers. I see you're closing #1481 - are there more steps required to enable connecting to containers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for containers as remote Remote development with containers Github codespaces
3 participants