feat: add support for generic paginators #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgaal
changed the title
szepeviktor
reviewed
Sep 14, 2022
erikgaal
force-pushed
the
pagination-generics
branch
from
9fd9c6e
to
c377a16
Compare
szepeviktor
approved these changes
Sep 14, 2022
canvural
requested changes
Oct 12, 2022
canvural
requested changes
Oct 14, 2022
erikgaal
force-pushed
the
pagination-generics
branch
from
f6fc138
to
2d25a23
Compare
canvural
requested changes
Oct 18, 2022
| @@ -28,8 +28,8 @@ abstract class AbstractPaginator implements \Illuminate\Contracts\Support\Htmlab | |||
| /** | |||
| * @template TValue | |||
| * | |||
| * @implements \ArrayAccess<mixed, TValue> | |||
| * @implements \IteratorAggregate<mixed, TValue> | |||
| * @implements \ArrayAccess<array-key, TValue> | |||
There was a problem hiding this comment.
Since this class implements ArrayAccess we should add the offset* methods here with the correct return/parameter types. This will let PHPStan know User::paginate(10)[3] returns User An example can be seen here.
Also for the other classes below + tests for this 👍🏽
|
That's great. Can you also resolve the conflict? Then if the CI is green, we can merge this! |
erikgaal
force-pushed
the
pagination-generics
branch
from
fa96aba
to
c1dc9d4
Compare
|
Errors from Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds support for generic paginators.
Before:
After:
Breaking changes