Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sail alias ignores args for local sail #9642

Closed
wants to merge 1 commit into from

Conversation

ulcuber
Copy link
Contributor

@ulcuber ulcuber commented May 7, 2024

No description provided.

@taylorotwell
Copy link
Member

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.

Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.

Thanks!

@ulcuber
Copy link
Contributor Author

ulcuber commented May 16, 2024

@taylorotwell

From man bash -> ALIASES:

There is no mechanism for using arguments in the replacement text. If arguments are needed, a shell function should be used (see FUNCTIONS below).

Alias is just a prefix string substituted instead of first word in command.

So sh vendor/bin/sail part receives all arguments while sh sail part receives nothing

For example the final expression for sail up would be like ([ -f sail ] && sh sail) || (sh vendor/bin/sail up). So instead of expected ./sail up it would be just ./sail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants