[7.x] Allow URL-encoded special characters in basic auth part of URLs #32181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Special characters in HTTP Basic Auth passwords in an URL need to be url-encoded. Example: foo@bar becomes foo%40bar, in an URL: http://user:foo%40bar@example.org The UrlValidator did not allow percent signs in username and password, and this is changed now. Related bugreport and fix for symfony: - symfony/symfony#36285 - symfony/symfony#36286
cweiske
force-pushed
the
urlvalidator-special-characters
branch
from
54bd257
to
17307fd
Compare
cweiske
changed the title
|
We will wait to see what Symfony does. For now you could |
|
urldecoding does not help, because that decodes the special characters in the password, which could be an |
|
Symfony merged the patch and today released 3 versions that contain the patch: |
|
I'll re-open this so Taylor can have another look. |
|
Loosk like there are some merge conflicts by now. @cweiske can you send in a new pr? |
|
Best that you send this to 6.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special characters in HTTP Basic Auth passwords in an URL need to be url-encoded.
Example: foo@bar becomes foo%40bar, in an URL: http://user:foo%40bar@example.org
The UrlValidator did not allow percent signs in username and password, and this is changed now.
Related bugreport and fix for symfony: