Revert "Update RouteRegistrar.php" #43523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d004416.
|
If there is a better solution feel free to PR. |
Ken-vdE
added a commit
to Ken-vdE/framework
that referenced
this pull request
Aug 9, 2022
This reverts commit d004416.
|
@Ken-vdE did you ever figure out a solution for this? I'm happy to take a look. |
|
@ollieread I haven't gotten around to it yet. Have at it ;) |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #43509
@taylorotwell This does not work and should be reverted. It seems the RouteRegistrar::__call() method does not pass the parameters correctly. The passed array is omitted there. I don't see a clear solution other then adding another if exception for the 'whereIn' just like the
if ($method === 'middleware') {statement in that __call method.Do you think that would be an acceptable solution?