[9.x] Fixes output when running db:seed or using --seed in migrate commands
#43593
+20
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
approved these changes
Aug 8, 2022
Ken-vdE
pushed a commit
to Ken-vdE/framework
that referenced
this pull request
Aug 9, 2022
…e commands (laravel#43593) * Fixes output on seeds * Apply fixes from StyleCI * Fixes tests Co-authored-by: StyleCI Bot <bot@styleci.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43515.
Recently, we have introduced a fresh new output for Artisan, and the
db:seedcommand:While this output is insanely pretty it does not play well when the user uses the
$this->command->info, or similar methods, to print output in the middle of the task:To address this issue, this pull request adopts a different approach that supports output being printed in the middle of a task: