Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep original keys when using Collection->sortBy() with an array of sort operations #43609

Merged
merged 2 commits into from Aug 9, 2022
Merged

Keep original keys when using Collection->sortBy() with an array of sort operations #43609

merged 2 commits into from Aug 9, 2022

Conversation

arthurperton
Copy link
Contributor

Fixes #43608 by using uasort() instead of usort().

@arthurperton arthurperton changed the title Keep original keys when using Collection->sortBy() with array of sort operations Keep original keys when using Collection->sortBy() with an array of sort operations Aug 9, 2022
@taylorotwell taylorotwell merged commit 7094bc1 into laravel:9.x Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collection: sortBy() on multiple attributes doesn't keep original keys
3 participants
@arthurperton @driesvints @taylorotwell