Skip to content

Ensure correct 'integrity' value is used for css assets #43714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

julesjanssen
Copy link
Contributor

@julesjanssen julesjanssen commented Aug 15, 2022

Like with a css resource that is a dependency of an import, a directly imported css file should also use its own manifest record to make sure the correct integrity value is applied.
Before this change, the <link would use the integrity key of the JS asset.

julesjanssen and others added 2 commits August 16, 2022 01:37

Unverified

No user is associated with the committer email.

Unverified

No user is associated with the committer email.
@julesjanssen julesjanssen marked this pull request as ready for review August 16, 2022 00:00
Copy link
Member

@timacdonald timacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this one. Tested and confirmed.

@taylorotwell taylorotwell merged commit fbd4648 into laravel:9.x Aug 16, 2022
@julesjanssen julesjanssen deleted the patch-1 branch August 16, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants