[9.x] Add a hook to the serialisation of collections #44272
Merged
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the use of parent/child Models in the same collection, to be properly serialized using the parent model (given a proper trait that facilitates the new function). Parent/child models as implemented in for example (https://github.com/calebporzio/parental) currently cause serialization errors when attempting to queue or otherwise serialize a collection containing them. This hook would allow us to alleviate the issue.
…sname-hook Allow hooking the queueable collection logic
Smoggert
added a commit
to Smoggert/parental
that referenced
this pull request
Sep 26, 2022
Update HasParent.php to fix collection serialization. Currently Parental creates unserializable Eloquent collections resulting in an error when pushing the colleciton to queue Queueing collections with multiple model types is not supported. I merged a framework request to create this callback on the model to circumvent the issue. laravel/framework#44272 This should fix the serialization error.
This was referenced Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the use of parent/child Models in the same collection, to be properly serialized using the parent model (given a proper trait that facilitates the new function provided).
Parent/child models as implemented in for example (https://github.com/calebporzio/parental) currently cause serialization errors when attempting to queue or otherwise serialize a collection containing them.
This hook would allow us to alleviate the issue.
If rather than checking for the existence of the function you'd rather just call the function, it can also easily be implemented on the model by default and then overwritten by the trait.