Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Revert PR #44613 #44672

Merged
merged 1 commit into from
Oct 20, 2022
Merged

[9.x] Revert PR #44613 #44672

merged 1 commit into from
Oct 20, 2022

Conversation

mtawil
Copy link
Contributor

@mtawil mtawil commented Oct 20, 2022

The previous PR #44613 is a breaking change. Changing the route parameter name is unrelated to the ORM!

My registration page is now crashed because of this change, and I've to override the fortify route file and change the {id} to {user_id}, so it will fit this PR! That doesn't make sense.

Here is my comment: #44613 (comment)

@mtawil mtawil changed the title Revert PR #44613 [9.x] Revert PR #44613 Oct 20, 2022
@taylorotwell taylorotwell merged commit 5b20be4 into laravel:9.x Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants