[9.x] add dictionary to slug helper #44730
Merged
+15
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the
Str::slug()
method already replaces the@
withat
. The keyboard still has some other replaceable characters.E.g
500$ bill
becomes500-dollar-bill
instead of500-bill
.Besides, some languages have different rules for the replacement of special characters.
With the current implementation, we can have something like:
which should be:
This PR adds a new parameter to the
Str::slug()
method to allow the developer to specify the replacement character for the special characters.It does not break the current implementation, as the default value for the new parameter is
['@' => 'at']
.