[10.x] Use atomic locks for command mutex #47624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gaitholabi
changed the title
Gaitholabi
force-pushed
the
10.x-use-atomic-locks-with-cli-commands
branch
from
8d641ba
to
bea99c9
Compare
Gaitholabi
changed the title
Gaitholabi
force-pushed
the
10.x-use-atomic-locks-with-cli-commands
branch
from
f2c46f9
to
f21ed5e
Compare
GrahamCampbell
changed the title
|
@GrahamCampbell could you please review this, when you get the chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The commands that implement the Isolatable feature depend on the caching functionality. When the command is running and we execute
php artisan cache:clearor call\Cache::flush();, this puts any pending isolated commands into an invalid state.This PR replaces the direct usage of Cache, with atomic locks, whenever the Cache driver supports it.