Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] Fix Str::replace return type #47779

Merged
merged 2 commits into from
Jul 20, 2023
Merged

[10.x] Fix Str::replace return type #47779

merged 2 commits into from
Jul 20, 2023

Conversation

datlechin
Copy link
Contributor

The str_replace or str_ireplace functions return array|string|string[], but currently Laravel only string.

@datlechin datlechin changed the title Fix Str::replace return type [10.x] Fix Str::replace return type Jul 19, 2023
GrahamCampbell
GrahamCampbell requested changes Jul 19, 2023
View reviewed changes
src/Illuminate/Support/Str.php Outdated Show resolved Hide resolved
GrahamCampbell
GrahamCampbell requested changes Jul 19, 2023
View reviewed changes
src/Illuminate/Support/Str.php Outdated Show resolved Hide resolved
@taylorotwell taylorotwell merged commit c59d540 into laravel:10.x Jul 20, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@datlechin @GrahamCampbell @taylorotwell