[10.x] Fix "Text file busy" error when call deleteDirectory #48422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycs77
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #41433 and adds tests
If you call the
File::deleteDirectory($dir)to delete a directory, you can see the files in the directory will be deleted, but the directory will keep it. If change the@rmdir()tormdir()intodeleteDirectory()it will be throws theErrorException: rmdir(/home/vagrant/packages/laravel-framework/vendor/orchestra/testbench-core/laravel/storage/app/public/testdir): Text file busyerror.So this PR fixed the "Text file busy" error on call
File::deleteDirectory($dir), unset the$itemsindeleteDirectory()to release the directory lock before callingrmdir(), does not break existing features.Reference PR: thephpleague/flysystem#1103, thephpleague/flysystem@d03f7e1