[10.x] Set prompt interactivity mode #48468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build will fail until laravel/prompts#73 is tagged as |
crynobone
added a commit
to laravel/prompts
that referenced
this pull request
Sep 22, 2023
* Require Laravel Framework 10.25+ : laravel/framework#48468 * Alias `dev-main` to `0.1.x-dev`
taylorotwell
pushed a commit
to laravel/prompts
that referenced
this pull request
Sep 22, 2023
* Update dependencies for 0.1.9 release * Require Laravel Framework 10.25+ : laravel/framework#48468 * Alias `dev-main` to `0.1.x-dev` * wip * wip
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
crynobone
force-pushed
the
non-interactive-prompts
branch
from
40b86ab
to
85bcb12
Compare
duncanmcclean
added a commit
to statamic/cms
that referenced
this pull request
Mar 15, 2024
When running the test suite on Laravel 10.0.0, Prompts would show me the interactive prompt, meaning the assertions wouldn't take place. Related: laravel/framework#48468
duncanmcclean
added a commit
to statamic/cms
that referenced
this pull request
Mar 15, 2024
When running the test suite on Laravel 10.0.0, Prompts would show me the interactive prompt, meaning the assertions wouldn't take place. Related: laravel/framework#48468
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Prompts in non-interactive mode, introduced in laravel/prompts#73.
Previously, Laravel would rely on the Prompts fallback behaviour (using Symfony) to handle commands that use the
-nargument to make them non-interactive, which is unrelated to whetherSTDINis a tty. This did not handle scenarios like CI, scheduled tasks, queued jobs, etc.A simpler solution would have been to enable the fallbacks when
STDINis not a TTY. However, I found Symfony's non-interactive behaviour a little unexpected. This feature also unlocks the ability for Prompts to provide default fallbacks (laravel/prompts#57) which removes the need for specifying them in the Laravel installer and other places where Laravel doesn't provide defaults.