Skip to content

[10.x] Allow for relation key to be an enum #50311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

AJenbo
Copy link
Contributor

@AJenbo AJenbo commented Feb 29, 2024

If a foring key is being cast to an enum calling ->sync() will cause a TypeError: Illegal offset type.

This resolves the issue by getting the value before using it as an array key.

AJenbo and others added 2 commits February 29, 2024 13:07

Verified

This commit was signed with the committer’s verified signature.
khepin Sebastien Armand
If a foring key is being cast to an enum calling ->sync() will cause a TypeError: Illegal offset type.

This resolves the issue by getting the value before using it as an array key.

Verified

This commit was signed with the committer’s verified signature.
khepin Sebastien Armand
@taylorotwell taylorotwell merged commit 3646b51 into laravel:10.x Feb 29, 2024
@AJenbo AJenbo deleted the patch-1 branch February 29, 2024 18:06
@GrahamCampbell GrahamCampbell changed the title Allow for relation key to be an enum [10.x] Allow for relation key to be an enum Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants