[11.x] Add generics for Arr::first() #50514

phh · 2024-03-13T13:59:37Z

I noticed PHPStan was not able to assert on Arr::first(). This however was possible in collection, so I just took some inspiration from there.

Reproduce:

$array = [new User];

\PHPStan\dumpType(Arr::first($array));
\PHPStan\dumpType(collect($array)->first());

Before:

Dumped type: mixed
Dumped type: App\Models\User|null

After:

Dumped type: App\Models\User|null
Dumped type: App\Models\User|null

This is greatly inspired by Collections and the types test

src/Illuminate/Collections/Arr.php

@return

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [laravel/framework](https://laravel.com) ([source](https://togithub.com/laravel/framework)) | `11.0.5` -> `11.0.8` | [![age](https://developer.mend.io/api/mc/badges/age/packagist/laravel%2fframework/11.0.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/laravel%2fframework/11.0.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/laravel%2fframework/11.0.5/11.0.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/laravel%2fframework/11.0.5/11.0.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>laravel/framework (laravel/framework)</summary> ### [`v11.0.8`](https://togithub.com/laravel/framework/compare/v11.0.7...v11.0.8) [Compare Source](https://togithub.com/laravel/framework/compare/v11.0.7...v11.0.8) ### [`v11.0.7`](https://togithub.com/laravel/framework/blob/HEAD/CHANGELOG.md#v1107---2024-03-15) [Compare Source](https://togithub.com/laravel/framework/compare/v11.0.6...v11.0.7) - \[11.x] Re-add translations for ValidationException by [@driesvints](https://togithub.com/driesvints) in [laravel/framework#50546 - \[11.x] Removes unused Dumpable trait by [@OussamaMater](https://togithub.com/OussamaMater) in [laravel/framework#50559 - \[11.x] Fix withRouting docblock type by [@santigarcor](https://togithub.com/santigarcor) in [laravel/framework#50563 - \[11.x] Fix docblock in FakeInvokedProcess.php by [@saMahmoudzadeh](https://togithub.com/saMahmoudzadeh) in [laravel/framework#50568 - \[11.x] fix: Add missing InvalidArgumentException import to Database/Schema/SqlServerBuilder by [@ayutaya](https://togithub.com/ayutaya) in [laravel/framework#50573 - \[11.x] Improved translation for displaying the count of errors in the validation message by [@andrey-helldar](https://togithub.com/andrey-helldar) in [laravel/framework#50560 - \[11.x] Fix retry_after to be an integer by [@driesvints](https://togithub.com/driesvints) in [laravel/framework#50580 - \[11.x] Use available `getPath()` instead of using `app_path()` to detect if base controller exists by [@crynobone](https://togithub.com/crynobone) in [laravel/framework#50583 - \[11.x] Fix doc block: `[@return](https://togithub.com/return) static` has been modified to `[@return](https://togithub.com/return) void` by [@saMahmoudzadeh](https://togithub.com/saMahmoudzadeh) in [laravel/framework#50592 - accept attributes for channels by [@taylorotwell](https://togithub.com/taylorotwell) in laravel/framework@398f494 ### [`v11.0.6`](https://togithub.com/laravel/framework/blob/HEAD/CHANGELOG.md#v1106---2024-03-14) [Compare Source](https://togithub.com/laravel/framework/compare/v11.0.5...v11.0.6) - \[11.x] Fix version constraints for illuminate/process by [@riesjart](https://togithub.com/riesjart) in [laravel/framework#50524 - \[11.x] Update Broadcasting Install Command With Bun Support by [@HDVinnie](https://togithub.com/HDVinnie) in [laravel/framework#50525 - \[11.x] Allows to comment `web` and `health` routes by [@nunomaduro](https://togithub.com/nunomaduro) in [laravel/framework#50533 - \[11.x] Add generics for Arr::first() by [@phh](https://togithub.com/phh) in [laravel/framework#50514 - Change default collation for MySQL by [@driesvints](https://togithub.com/driesvints) in [laravel/framework#50555 - \[11.x] Fixes install:broadcasting command by [@joedixon](https://togithub.com/joedixon) in [laravel/framework#50550 - \[11.x] Fix crash when configuration directory is non-existing by [@buismaarten](https://togithub.com/buismaarten) in [laravel/framework#50537 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tisnamuliarta/laravel-shadcn).

Add generics for Arr::first()

dae8777

nunomaduro requested changes Mar 13, 2024

View reviewed changes

src/Illuminate/Collections/Arr.php Outdated Show resolved Hide resolved

src/Illuminate/Collections/Arr.php Outdated Show resolved Hide resolved

src/Illuminate/Collections/Arr.php Show resolved Hide resolved

Add TKey

ccba6c1

nunomaduro approved these changes Mar 13, 2024

View reviewed changes

taylorotwell merged commit 08acc92 into laravel:11.x Mar 13, 2024
28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.x] Add generics for Arr::first() #50514

[11.x] Add generics for Arr::first() #50514

phh commented Mar 13, 2024

[11.x] Add generics for Arr::first() #50514

[11.x] Add generics for Arr::first() #50514

Conversation

phh commented Mar 13, 2024