[11.x] Removes unused Dumpable trait #50559
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
Dumpable
trait was added here, you can see that thedd()
method was removed. However, I noticed that it has been reintroduced (maybe when merging [10.x] to [11.x]). Consequently, for theBuilder
class, the trait is never used; its methods are being overridden by the local ones, which display the raw SQL and its bindings.