[11.x] Fix query builder whereBetween with CarbonPeriod and Carbon 3

[bakerkretzmar]

This PR fixes the query builder's whereBetween() and havingBetween() methods by calling getStartDate() and getEndDate() on CarbonPeriod, instead of using its $start and $end properties. Currently, using Carbon 3, $period->start is always 2000-01-01 and $period->end is always null (see briannesbitt/Carbon#2982).

In Carbon 2 this is actually exactly what $start and $end already do—they are not defined, so they go through the CarbonPeriod class's __get() method, which calls getStartDate() and getEndDate() (https://github.com/briannesbitt/Carbon/blob/2.x/src/Carbon/CarbonPeriod.php#L757).

In Carbon 3 those getters are all still set up exactly the same way, but they don't work (I assume this was unintentional). CarbonPeriod now extends PHP's DatePeriod class, which actually defines $start and $end properties, so the getters are never called.

[kylekatarnls]

In Carbon 3 those getters are all still set up exactly the same way

No, they are no longer getters because readonly properties are set in the parent DatePeriod constructor so we don't have control of them in the sub-class.

In Carbon v2 CarbonPeriod was not extending DatePeriod (because PHP didn't allow it properly before 8.1)

I'm trying to rethink the CarbonPeriod constructor so to have them set at creation. But using getStartDate() and getEndDate() would be a good move anyway. BTW those methods also exist on DatePeriod so it could be supported too.

And another note: DatePeriod (and CarbonPeriod) don't always have an end, it can have a number of recurrences instead.

[bakerkretzmar]

No, they are no longer getters because readonly properties are set in the parent DatePeriod constructor so we don't have control of them in the sub-class.

Yeah that's more or less what I meant—the getters don't work that way anymore but looking at the code it seems like they were intended to, because the mappings for start, end, etc. are still listed where all the getters are handled.

BTW those methods also exist on DatePeriod so it could be supported too.

Cool, didn't realize that! whereBetween() can probably be updated to support that too then yeah.