-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.x] Str trim methods #50822
Merged
Merged
[11.x] Str trim methods #50822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickomeara
force-pushed
the
str-trim-methods
branch
from
March 29, 2024 22:48
8d1286a
to
7acdbfe
Compare
patrickomeara
force-pushed
the
str-trim-methods
branch
from
March 29, 2024 23:23
7acdbfe
to
a266fb5
Compare
@patrickomeara why is the white space removed by |
@taylorotwell The whitespace characters are the same, ltrim removes it from the beginning |
Got it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native methods
trim()
,ltrim()
andrtrim()
don't remove the unicode whitecode characterNBSP
.Str::squish()
removes these characters, as doesTrimStrings
middleware.This PR adds
trim()
,ltrim()
andrtrim()
static methods to theStr
helper, and also uses these methods in the corresponding Stringable calls.Note: For reviewers the whitespace characters don't show up in the web UI.
Test screenshots attached to show them.