Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Rehash user passwords when logging in once #50843

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

axlon
Copy link
Contributor

@axlon axlon commented Mar 29, 2024

This PR is a followup to #48665, it adds the automatic rehashing feature to SessionGuard::once(). I couldn't find any obvious reasons why this method wasn't included in the original PR, so I assume it was accidentally skipped.

My personal use-case is that we use SessionGuard::once() to perform the initial authentication of a user, we then decide if we require further authentication based on various factors.

@axlon axlon changed the title [11.x] Rehash user passwords when validating credentials [11.x] Rehash user passwords when logging in once Mar 29, 2024
@taylorotwell taylorotwell merged commit a6de7c6 into laravel:11.x Mar 29, 2024
28 checks passed
@axlon axlon deleted the session-guard-once-rehash branch March 29, 2024 14:35
@valorin
Copy link
Contributor

valorin commented Apr 4, 2024

Nice work, thanks for doing this! 😁

I completely overlooked this use case when I did the original PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants