[10.x] Binding order is incorrect when using cursor paginate with multiple unions with a where #50884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorotwell
reviewed
Apr 9, 2024
|
I dunno - if the bindings were being duplicated this PR was already apparently broken? Why did the tests not show that? It shakes my confidence in merging 😅 |
|
Yeah I agree that that doesn't look too solid. |
|
I've given each builder its own variable name to make it a little bit easier to see what's going on. |
|
@thijsvdanker please mark this as ready if you need another review. |
|
I've added an Eloquent test that demonstrates the issue: 3e87617 |
crynobone
approved these changes
Apr 16, 2024
crynobone
requested changes
Apr 16, 2024
crynobone
approved these changes
Apr 16, 2024
crynobone
reviewed
Apr 16, 2024
crynobone
reviewed
Apr 16, 2024
Co-authored-by: Mior Muhammad Zaki <crynobone@gmail.com>
Co-authored-by: Mior Muhammad Zaki <crynobone@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
cursorPaginateon a query that has multiple unions with their own where clause, the binding order is incorrect.This happens because:
https://github.com/laravel/framework/blob/11.x/src/Illuminate/Database/Concerns/BuildsQueries.php#L436
adds the bindings for the cursor
whereto the end of the bindings and not in the position that they should be.The result is a query that binds the wrong values to the wrong parameters in the query.
This PR recreates the union bindings in the cursor paginate logic so that the cursor
wherebinding is in the correct position.This PR is similar to #50810 but does not change the structure of the union binding to address the fear of a breaking change.
Instead it is only applied in the context of cursor pagination.