Add Conditionable trait to Testing\PendingCommand.php

[tobz-nz]

When testing an Artisan command, the command it not actually run until the chain is destructed (see this discussion) - meaning you cannot set the result to a variable to append additional assertions to depending on test dataset context.
For example asserting the output based on different inputs.

// terrible example
test('example', function (bool $value) {
    $result = $this->artisan('update-table-command', ['value' => $value]);

    if ($value == true) {
        $result->assertOutput('setting X turned on');
    }

    if ($value == false) {
        $result->assertOutput('setting X turned off');
    }
});

The simple solution for this use case is to add the Conditionable trait to PendingCommand - problem solved.
You can now easily add more assertions based on dataset criteria.

// terrible example
test('example', function (bool $value) {
    $this->artisan('update-table-command', ['value' => $value])
        ->when(
            $value, 
            fn ($result) => $result->assertOutput('setting X turned on'),
            fn ($result) => $result->assertOutput('setting X turned off')
        );
});

[github-actions]

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

[tobz-nz]

I've not got any tests for this because I'm not sure how to go about it to be honest. Could someone help with that?

[devajmeireles]

I've not got any tests for this because I'm not sure how to go about it to be honest. Could someone help with that?

Fixing StyleCI should be enough. We all know what Conditionable does.

[tobz-nz]

@devajmeireles .. I can't see the circle ci checked..?

[devajmeireles]

@devajmeireles .. I can't see the circle ci checked..?

Scroll down, it's always the first check.