[12.x] Remove unused parameter $connection
#51330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Databases nightly workflow * Fix indention * Continue on error Co-authored-by: Mior Muhammad Zaki <crynobone@gmail.com> --------- Co-authored-by: Mior Muhammad Zaki <crynobone@gmail.com>
add "or equal to" so the comment is accurate for the behavior of the method.
* [11.x] Introduce method `Rule::array()` * CS fixes * Add `func_get_args` test * formatting --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
laravel#51289) * Add tests for handling non-baked enum and empty string requests * use existing request key --------- Co-authored-by: Hrant Aghanian <haghanian@ronasit.com>
* filled and blank works with `Stringable` * unnecessary --------- Co-authored-by: stefan.riedel <stefan.riedel@arbeitsmedizin.de>
* fix image ration validation for high ratio images * fix style ci * enhance comments * enhance precision equation * enhance precision equation * enhance precision equation
* Prevent int * Update helpers.php * leaved only PHPdoc part
* Add release notes So it's clear how to do releases for the framework repo. * Update RELEASE.md --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
* filled and blank works with `Stringable` * unnecessary * `Stringable` is also an interface from symfony and is implemented on models. So if we check a model if a model is filled it except an error: Call to undefined method App\\Model::trim(). So we use now explicit Illuminate\Support\Stringable * reduce compare to native trim - function * unnused Model --------- Co-authored-by: stefan.riedel <stefan.riedel@arbeitsmedizin.de>
…application (laravel#51292) * add ability to loading cached Routes for application using callback * remove method --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
* add mysql json_overlaps * update error message * update comments * formatting --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
…51316) * feat: Add `exists` method to `ValidatedInput` * feat: Add `hasAny` method to `ValidatedInput` * feat: Add `whenHas` method to `ValidatedInput` * feat: Add `filled` method to `ValidatedInput` * feat: Add `isNotFilled` method to `ValidatedInput` * feat: Add `anyFilled` method to `ValidatedInput` * feat: Add `whenFilled` method to `ValidatedInput` * feat: Add `whenMissing` method to `ValidatedInput` * feat: Add `isEmptyString` method to `ValidatedInput` * feat: Add `keys` method to `ValidatedInput` * feat: Add `input` method to `ValidatedInput` * feat: Add `string` method to `ValidatedInput` * feat: Add `str` method to `ValidatedInput` * feat: Add `boolean` method to `ValidatedInput` * feat: Add `integer` method to `ValidatedInput` * feat: Add `float` method to `ValidatedInput` * feat: Add `date` method to `ValidatedInput` * feat: Add `enum` method to `ValidatedInput` * feat: Add `dump` method to `ValidatedInput` * feat: Add `dd` method to `ValidatedInput` * refactor: Add `$key` prop to `collect` method in `ValidatedInput` * refactor: Change usages `$this->input` to `$this->all()` * refactor: Change usages `$this->input[$key]` to `$this->input($key)` * refactor: Change usages `isset($this->input[$name])` to `$this->exists($name)` * test: Added tests * formatting * formatting * formatting --------- Co-authored-by: Fatih Aydın <fatihaydin@temizlikyolda.com> Co-authored-by: Taylor Otwell <taylor@laravel.com>
* Adding PasswordResetLinkSent event * formatting * formatting --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
…entIndexes, addImpliedCommands methods
|
Changing method signatures is a breaking change, this cannot target 11.x |
|
Hi @Jacobs63 These changes pertain to two protected methods that are not used anywhere else externally. Of course, I can also send it for version 12, depending on @taylorotwell approval and feedback. In fact, we haven't made any changes to the |
Which, still, doesn't mean someone couldn't have extended the Blueprint class in their codebase, making this a breaking change. |
|
Great, no problem. We can send it in version 12. |
saMahmoudzadeh
changed the title
$connection$connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, removes the unused parameter
$connectionfrom the methodsaddFluentCommands,addFluentIndexes, andaddImpliedCommands.