feature: rename react components #419
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need for future changes to be able to access and build queries from any connector when resolving the queries in a specific connector. To make our life easier we pass the source manager through the Source to the connector
We want to move the responsability of fining the query in the file system from the connector to the source. After the last refactor now this is easier to todo because we have access to the source and the source manager in the connector. With this change is easier to pass the the full path of the query and look for relative paths and paths that lives outside the source of the connector. We want to do both things in the upcoming changes
This commit just introduce the materialize connector but is will need another piece to work that we'll introduce in another PR. For now we don't publish this connector
🦋 Changeset detectedLatest commit: e5478c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
geclos
force-pushed
the
feature/rename_default_react_components
branch
3 times, most recently
from
8f524fb
to
5258f88
Compare
andresgutgon
previously approved these changes
May 14, 2024
geclos
force-pushed
the
feature/rename_default_react_components
branch
from
5258f88
to
f64d0f0
Compare
geclos
force-pushed
the
feature/rename_default_react_components
branch
2 times, most recently
from
bef8be8
to
4cde250
Compare
geclos
force-pushed
the
feature/rename_default_react_components
branch
from
4cde250
to
52868a6
Compare
Removes the Query prefix from those components that have the same api than components in Latitude app. Before: AreaChart in Latitude app corresponded to AreaChartQuery in react library In this commit: AreaChart in Latitude app corresponds to AreaChart in react library To accommodate this change, I've added a Data suffix to raw components
geclos
force-pushed
the
feature/rename_default_react_components
branch
from
52868a6
to
e5478c1
Compare
csansoon
force-pushed
the
canary
branch
4 times, most recently
from
afdf18e
to
3bf82b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Removes the Query prefix from those components that have the same api than components in Latitude app.
Before:
AreaChart in Latitude app corresponded to AreaChartQuery in react library
In this commit:
AreaChart in Latitude app corresponds to AreaChart in react library
To accomodate this change, I've added a Data suffix to raw components
Issue ticket number and link
Checklist before requesting a review