minor: refactor stores/queries code #426
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
computeQueryParameters was returning view parameters with undefined values which is not the desirable behaviour.
|
geclos
force-pushed
the
feature/refactor_query_stores_code
branch
from
0d5f7bc
to
66c22f3
Compare
Improve a bit the code as it was quite hard to follow
geclos
force-pushed
the
feature/refactor_query_stores_code
branch
from
66c22f3
to
7f0b19c
Compare
geclos
force-pushed
the
fix/undefined_passed_to_query_computes
branch
3 times, most recently
from
101b87e
to
b66603f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Improve a bit the code as it was quite hard to follow
Checklist before requesting a review