Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(templates): fix templates tsc errors and add test #2036

Merged
merged 7 commits into from
Jan 3, 2024
Merged

fix(templates): fix templates tsc errors and add test #2036

merged 7 commits into from
Jan 3, 2024

Commits on Dec 6, 2023

  1. create-mud: detect errors by running pnpm test in each template

    @tash-2s
    tash-2s committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    003e2b7 View commit details
    Browse the repository at this point in the history

  2. templates: add missing dev dependencies 

    `pnpm add --workspace-root --save-dev @types/debug@4.1.7 @types/prettier@2.7.2`
    @tash-2s
    tash-2s committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    76b54b6 View commit details
    Browse the repository at this point in the history

  3. templates/vanilla: add missing dev dependencies 

    `pnpm --filter client add --save-dev @types/react-dom@18.2.7`
    @tash-2s
    tash-2s committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    563f079 View commit details
    Browse the repository at this point in the history

  4. create-mud: full test in templates might be redundant, skip mud test

    @tash-2s
    tash-2s committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    9455328 View commit details
    Browse the repository at this point in the history

  5. create-mud: revert changes 

    This test specifies the main tag, but there's a problem with that. When we make a breaking change in our library and fix the templates along with it, this test fails. Instead of main, we should use locally packed dependencies.
    @tash-2s
    tash-2s committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    b675f08 View commit details
    Browse the repository at this point in the history

  6. add github actions workflow testing create-mud project

    @tash-2s
    tash-2s committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    cf533e5 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Merge branch 'main' into test-and-fix

    @alvrs
    alvrs committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    c82181a View commit details
    Browse the repository at this point in the history