Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade vitest to 0.34.6 #2193

Merged
merged 5 commits into from Jan 26, 2024
Merged

Conversation

yonadaaa
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Jan 25, 2024

⚠️ No Changeset found

Latest commit: cbfe370

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

@yonadaaa yonadaaa Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems toEqualTypeOf is bugged with zod: vitest-dev/vitest#4114

Copy link
Contributor Author

@yonadaaa yonadaaa Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find a version that fixes the benchmarking issue but doesn't also introduce this MISMATCH issue... wonder if it's worth just upgrading vitest in store-sync where we really need it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just upgrading store-sync seems fine to me!

could also try bumping zod to see if this was fixed there?

@@ -30,7 +30,7 @@
"typescript": "5.1.6",
"viem": "1.14.0",
"vite": "^4.2.1",
"vitest": "^0.31.0",
"vitest": "0.31.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentionally not bumping this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops, missed that in my ctrl-f

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just upgrading store-sync seems fine to me!

could also try bumping zod to see if this was fixed there?

@tash-2s
Copy link
Contributor

tash-2s commented Jan 26, 2024

The errors in the previous PR #2190 appear to be caused by the following reasons, though not confirmed:

  1. Error: Definitions of the following identifiers conflict with those in another file
  2. Error: Cannot find module 'rollup/parseAst' or its corresponding type declarations.
  3. Error: Cannot find name 'WeakKey'

Regarding the toEqualTypeOf problem, it seems there is no easy fix at the moment. toMatchTypeOf is a looser alternative than toEqualTypeOf, as it allows extra properties, but it works.

Copy link
Member

@holic holic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yonadaaa yonadaaa merged commit 6ca974b into main Jan 26, 2024
11 checks passed
@yonadaaa yonadaaa deleted the yonadaaa/upgrade-vitest-0.34.6 branch January 26, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants