Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP world call library generation #2461

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP world call library generation #2461

wants to merge 1 commit into from

Conversation

dk1a
Copy link
Member

@dk1a dk1a commented Mar 18, 2024

fixes #2319

some issues/TODOs:

  • namespace argument
  • world argument (these can even be options, like storeArgument)
  • separation of worldgen and libgen(?), if it's even necessary - they both share the contractToInterface call
  • all lib methods have highest mutability (not view/pure), because of how World's call works
  • not sure encodeCall will work correctly with overloaded signatures

Copy link

changeset-bot bot commented Mar 18, 2024

⚠️ No Changeset found

Latest commit: 7deb346

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library auto-generation for non-root Modules
1 participant