Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guides/adding-delegation): change to account for API changes 馃弾 #2837

Merged
merged 5 commits into from
May 16, 2024

Conversation

qbzzt
Copy link
Contributor

@qbzzt qbzzt commented May 15, 2024

Specifically, change App.tsx to account for the fact getContract now wants a structure with the two clients.

Copy link

changeset-bot bot commented May 15, 2024

鈿狅笍 No Changeset found

Latest commit: 477b84c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -429,7 +430,7 @@ const publicClient = createPublicClient({
// client - a wallet client that uses a random account
Copy link
Member

@holic holic May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're not returning this anymore, so I don't think we need this comment?
and that said, should we just return the getContract result rather than { world: getContract(...) }?

nevermind, I see references in code below that still use client so maybe we should restore the returned client as client: walletClient?

@holic holic merged commit 2d9ec18 into main May 16, 2024
3 of 5 checks passed
@holic holic deleted the 240515-update-delegation branch May 16, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants