Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LAUD-302 - Comprehensive Multisplit #334

Open
wants to merge 26 commits into
base: staging
Choose a base branch
from
Open

LAUD-302 - Comprehensive Multisplit #334

wants to merge 26 commits into from

Conversation

gitstart-app[bot]
Copy link
Contributor

@gitstart-app gitstart-app bot commented Mar 12, 2024

Description

Comprehensive multisplit

Refs

#302

Demo

Multisplit

test_multisplit.mp4

uploadCSV

uploadCSV.mp4

Fixes #302

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
@gitstart-laudspeaker
Copy link
Collaborator

gitstart-laudspeaker commented Mar 12, 2024

Hey @abheek9 Please check out these notes

Notes

During the testing, I found it unnecessary to manually import CSV files since the process involves numerous steps and needs to be performed in multiple tests repeatedly. Instead, I created a dedicated test specifically for the import CSV functionality. In this multi-split test, I addressed the import CSV functionality by directly issuing the network requests it involves. However, we can still include the entire uploadCSV functionality directly in the multisplit test if you find it appropriate.

Regarding the ticket description, it states that we should issue network requests to the events endpoint for each user attribute in the multisplit. However, I am still unclear about how this is linked to the multisplit. I understand that the multisplit triggers webhooks when certain conditions are met, such as a 1-minute delay and conditions in the multisplit branches. These conditions, however, seem unrelated to the events API. Could you please clarify how the events API connects with the multisplit?

test_multisplit_conditions.mp4

@gitstart-laudspeaker gitstart-laudspeaker marked this pull request as ready for review March 12, 2024 13:15
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
@gitstart-laudspeaker
Copy link
Collaborator

The uploadCSV API call is failing in CI, any idea why?

Screenshot 2024-03-13 at 07 10 58

gitstart-laudspeaker and others added 18 commits March 14, 2024 15:37
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
@abheek9
Copy link
Contributor

abheek9 commented Apr 3, 2024

@gitstart-laudspeaker this test does not look correct, right now each branch is using the same webhook, but in the instructions, each branch uses a different webhook. This is important because we need to know which branch is triggered from a specific event

@gitstart-laudspeaker
Copy link
Collaborator

gitstart-laudspeaker commented Apr 3, 2024

@gitstart-laudspeaker this test does not look correct, right now each branch is using the same webhook, but in the instructions, each branch uses a different webhook. This is important because we need to know which branch is triggered from a specific event

Hey @abheek9 The webhooks are mentioned in the video description of the video, but it only mentions that the webhook can be our events endpoint. If you look closely at the webhooks, you notice that 3 branches share a webhook, and 2 also share a webhook.

@gitstart-laudspeaker
Copy link
Collaborator

Hey @abheek9 Earlier I had asked for clarification on how the events and the webhooks are connected, now it makes sense. So, if we use the events endpoint in the webhooks, then the multisplit branches can each trigger a different event, we can then check the triggered events to confirm that the multisplit actually triggers the webhooks

@gitstart-laudspeaker
Copy link
Collaborator

gitstart-laudspeaker commented Apr 3, 2024

Hey @abheek9
I've updated the tests as illustrated below

multi-split.mp4
  • Each branch is attached to a different webhook
  • When the branch calls the webhook, it will emit an event to the events endpoint

However, I cannot see the events in the event-tracker meaning the API calls are not actually made, at what point are the users enrolled in the journeys(I also see no users in the journey) so that the web-hooks are triggered. I also created the journey manually as a normal user would and still don't see the events. Perhaps you can provide some insight into how the various branches are triggered.

events.mp4

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
gitstart-laudspeaker and others added 3 commits April 23, 2024 14:38
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comprehensive Multisplit
2 participants