Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2407): respect the HaltIfNull opcode when determining nullability #2409

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

arlyon
Copy link
Contributor

@arlyon arlyon commented Mar 17, 2023

This closes #2407

The issue describes the situation. The HaltIfNull opcode was not being respected, causing the macro to spit out optionals for types that could never be null.

This PR fixes it :)

@abonander abonander merged commit bd3eb94 into launchbadge:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

query_as returning Option<T> when using 'returning' syntax on sqlite
2 participants