Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #2549 - cannot use feature "rust_decimal" without also using "bigdecimal" #2585

Merged
merged 5 commits into from
Jul 6, 2023

Conversation

deneut
Copy link
Contributor

@deneut deneut commented Jul 5, 2023

Fix for this issue.

When trying to use the (newly renamed) rust_decimal feature in version 7.0.0, compiling fails because there is a missing dependency on num-bigint and numerous places in the code where the previous feature name of decimal was not updated to the new name of rust_decimal.

Even if one includes the bigdecimal feature when using the current code on main, rust_decimal functionality is not restored (although it is then possible to compile) because the macros still return BigDecimal for all NUMERIC Postgres types.

This small patch fixes those issues and restores rust_decimal functionality.

@deneut deneut changed the title Fix for Issue #2549 - cannot use feature "rust_decimal" without also using "bigdecimal" Fix for Issue launchbadge/sqlx#2549 - cannot use feature "rust_decimal" without also using "bigdecimal" Jul 5, 2023
@deneut deneut changed the title Fix for Issue launchbadge/sqlx#2549 - cannot use feature "rust_decimal" without also using "bigdecimal" Fix for Issue #2549 - cannot use feature "rust_decimal" without also using "bigdecimal" Jul 5, 2023
@Jezza
Copy link

Jezza commented Jul 6, 2023

Bump.

I'd love for this to get merged. :D

@cemoktra
Copy link
Contributor

cemoktra commented Jul 6, 2023

Yes this blocks migrating to 0.7

@abonander abonander merged commit 258eaca into launchbadge:main Jul 6, 2023
57 checks passed
@cemoktra
Copy link
Contributor

@abonander will there be a 0.7.1 soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants