Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct mention of the tls-native-tls in the documentation. #2593

Merged
merged 1 commit into from
Jul 8, 2023
Merged

Correct mention of the tls-native-tls in the documentation. #2593

merged 1 commit into from
Jul 8, 2023

Conversation

denschub
Copy link
Contributor

@denschub denschub commented Jul 7, 2023

The feature is called tls-native-tls, not tls-native:

tls-native-tls = ["sqlx-core/_tls-native-tls", "sqlx-macros?/_tls-native-tls"]

So all the existing documentation is wrong.

I'd personally probably prefer tls-native as a feature name, but I wasn't sure if it's a good move to just change the name of that feature, so I decided to PR the docs change first. :)

@abonander
Copy link
Collaborator

Yeah I vacillated on what to call the feature, but decided to make it the same as the crate name it uses, for consistency.

@abonander abonander merged commit b283a31 into launchbadge:main Jul 8, 2023
57 checks passed
@denschub denschub deleted the fix-native-tls-feature branch July 8, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants