Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bumping slsa-github-generator version to resolve issue with retrieving Rekor public keys #386

Merged
merged 1 commit into from Apr 2, 2024

Conversation

rsoberano-ld
Copy link
Contributor

Provenance generation fails due to Rekor public key errors were identified as a known issue and fixed in version 1.10.0 per: slsa-framework/slsa-github-generator#3350

@rsoberano-ld rsoberano-ld requested a review from a team as a code owner April 2, 2024 22:45
Copy link
Member

@kinyoklion kinyoklion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rsoberano-ld
Copy link
Contributor Author

Should we consider rennovate for this?

https://github.com/slsa-framework/slsa-github-generator/blob/main/RENOVATE.md

I'm a little confused - this snippet would setup a Renovate exception to allow us to use tags for slsa-github-generator if Renovate was blocking tags in favor of digests previously, which I don't think is what is going on here(?)

@kinyoklion
Copy link
Member

Should we consider rennovate for this?
https://github.com/slsa-framework/slsa-github-generator/blob/main/RENOVATE.md

I'm a little confused - this snippet would setup a Renovate exception to allow us to use tags for slsa-github-generator if Renovate was blocking tags in favor of digests previously, which I don't think is what is going on here(?)

It is their best practice for using rennovate, we could also do it without that. It just seems reasonable to automate it.

@rsoberano-ld
Copy link
Contributor Author

Should we consider rennovate for this?
https://github.com/slsa-framework/slsa-github-generator/blob/main/RENOVATE.md

I'm a little confused - this snippet would setup a Renovate exception to allow us to use tags for slsa-github-generator if Renovate was blocking tags in favor of digests previously, which I don't think is what is going on here(?)

It is their best practice for using rennovate, we could also do it without that. It just seems reasonable to automate it.

Ahh I see what you mean - I do agree having Renovate in general would be helpful here to help keep us up to date, especially when it comes to bumping up these versions across all of our SDK repos.

@rsoberano-ld rsoberano-ld merged commit 03449b3 into main Apr 2, 2024
20 checks passed
@rsoberano-ld rsoberano-ld deleted the rsoberano/SEC-5264/slsa-generator-bump branch April 2, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants