Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep the repo for building a Node 20 binary #35

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

maschwenk
Copy link
Contributor

@maschwenk maschwenk commented Nov 15, 2023

  1. Simplify the process outlined in the README
  2. Upgrade node-gyp. Was unable to complete the installation until I did that. Can't find the logs 馃槩
  3. Update the Node version in the Dockerfile
  4. Remove the docker-compose file. We're not composing multiple services/networks so I think overkill here. Easier to just build and then run in a one-liner IMO.

@luanxuechao
Copy link

Hi @pyramation, do you plan to merge this PR? My team have a security issue in node-gyp---->glob---->inflight, when the node-gyp upgrade to ^10, the inflight will removed.

@pyramation
Copy link
Collaborator

pyramation commented Dec 15, 2023

@benasher44 can you check this

@darora can you help us build this one?

@karlhorky
Copy link
Contributor

I guess this can be closed, since the binaries for Node.js 20.x for linux/amd64, linux/arm64, darwin/arm64 have been published by @darora :

@maschwenk
Copy link
Contributor Author

I think the process of creating the binaries should be relatively reproducible by someone other than @darora? If only @darora can generate them it creates a bus factor going forward. AFAICT this repo as-is can't create the binaries because of issues in node-gyp.

@benasher44
Copy link
Contributor

benasher44 commented Jan 9, 2024

Any suggestions on a free place to host them? I think that's the main blocker right now. The build issues can be otherwise overcome

@maschwenk
Copy link
Contributor Author

@benasher44 that's a concern for sure, and no I don't have a great suggestion other than Github Releases? This PR doesn't try to tackle that, it's just to make it so that someone can checkout this repo and build at least the Linux binaries themselves.

@benasher44
Copy link
Contributor

Fair! Change look good to me

@pyramation pyramation merged commit e8b09a9 into launchql:master Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants