Mobile,Desktop: Fix nonbreaking spaces and CRLF break search for adjacent words #10417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an issue reported on the forum: Limitations of Searching in Joplin.
Previously, non-breaking spaces (
\u00A0) and CRLF seem to have been treated as word characters instead of separators by the FTS tokenizer. This pull request converts them to space characters during text normalization, which are marked as separators.Note
Existing notes will need to be re-indexed for this change to apply.
Testing
This pull request includes an automated test. However, it can also be tested manually by:
console.log('\u00A0searchquerytesta\r\nsearchquerytestb').searchquerytestaand verify that the just-created note is in the results.searchquerytestband verify that the just-created note is in the results.