Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #6813: Upgrade electron to 19.0.10 #6888

Merged
merged 3 commits into from Oct 15, 2022

Conversation

brad
Copy link
Contributor

@brad brad commented Sep 27, 2022

Fixes #6813

Under Asahi Linux I tried Joplin with a few different electron versions with these results

  • 18.2.0 ❌
  • 18.3.2 ❌
  • 18.3.6 ❌
  • 19.0.0 ✅
  • 19.0.10 ✅

So it looks like the fix was introduced in 19.0.0 (since there were no releases between 18.3.6 and 19.0.0) but I set the version to 19.0.10 to take advantage of any bug fixes on the minor releases.

@laurent22
Copy link
Owner

Any Electron upgrades need to be thoroughly tested. Please see other Electron upgrade pull request for more info.

@brad
Copy link
Contributor Author

brad commented Sep 30, 2022

@laurent22 Good point. I've been using it for a few days but not really putting it through it's paces so I'll do that. In the meantime, I did just take a look at breaking changes in the release notes and couldn't find any places in the code that would be affected by them

Unsupported on Linux: .skipTaskbar
The BrowserWindow constructor option skipTaskbar is no longer supported on Linux. Changed in #33226

Removed WebPreferences.preloadURL
The semi-documented preloadURL property has been removed from WebPreferences. #33228. WebPreferences.preload should be used instead.

@brad
Copy link
Contributor Author

brad commented Oct 13, 2022

@laurent22 I've tested the following

  • printing
  • export (tried with pdf and html)
  • file attachment (tried with an image)
  • plugins (I tried bulk note plugin)
  • sync (with dropbox)
  • external editing

@laurent22
Copy link
Owner

Thanks for testing all this! Let's merge

@laurent22 laurent22 merged commit c9ff0a3 into laurent22:dev Oct 15, 2022
@brad brad deleted the feature/support-asahi-linux branch October 16, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants