Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a result of ["ok", {"error": []}] failed, when it was clearly OK #184

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

francois
Copy link

@francois francois commented Sep 3, 2021

We upgraded Rails from 6.0.3.7 to 6.1.4.

We were receiving errors with no error message: "Uglifier::Error: ".

When I debugged the issue, I was able to find the following:

[211, 220] in vendor/bundle/ruby/2.7.0/gems/execjs-2.8.1/lib/execjs/external_runtime.rb
   211:         def exec_runtime(filename)
   212:           io = IO.popen(binary.split(' ') << filename, **(@popen_options.merge({err: [:child, :out]})))
   213:           output = io.read
   214:           io.close
   215:
=> 216:           if $?.success?
   217:             output
   218:           else
   219:             raise exec_runtime_error(output)
   220:           end
(byebug) #<Process::Status: pid 3561 exit 0>

Clearly, the output meant "all is OK", but Uglifier didn't treat it as such. I applied this patch in an effort to mitigate the issue for now.

Happy to discuss improvements I can apply to get this, or something similar, merged.

@Jaco-Pretorius
Copy link

+1 I'm also seeing this after a recent upgrade to Rails 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants